namespace support in helm chart#74
Draft
prudnitskiy wants to merge 2 commits into
Draft
Conversation
Member
|
Hi @prudnitskiy, thanks for your contribution! Could you explain why it's necessary to specify the namespace manually in the resources? Doesn't running |
Author
|
Hi @Endevir, The namespace doesn't always work correctly if passed as argument. It is also important for ArgoCD, Flux and Kustomize users that pass namespace as a helm chart property. By default, Helm renders chart to the current namespace. This contribution does not change Helm chart behaviour for normal use but helps to use helm as an interim tool. |
Contributor
|
Usually charts don't use "namespace" generally and flux "targetNamespace" works as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A small PR enables namespaces for helm chart.
Type of change
How Has This Been Tested?
Test deployment to the separate cluster
Checklist: